Kami commented on issue #1387: GCENodeDriver's deploy_node() now accepts Deployments as well as all the parameters accepted by create_node() URL: https://github.com/apache/libcloud/pull/1387#issuecomment-568109744 @yukw777 I went ahead and merged all those changes into master. Thanks again for your contribution. Overall, I think this change is reasonable and good since ``deploy_node()`` now complies with the base compute API. We could also get ``deploy_node()`` functionality to work without actually needing to SSH into the server and simply utilizing ``startup-script`` metadadata functionality (same as before), but that has limitations and doesn't comply with the Libcloud base API (startup script is limited in size which is true for most providers which utilize cloud init like systems for managing startup scripts). /cc @erjohnso ^ --- On a somewhat related note, I'm also looking into a change so we can exclude ``auth`` argument from ``create_node()`` method signature where it's not needed (aka as in GCE driver case). And since this is a backward incompatible change, we also need to add entry to Upgrade notes file.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
