Kami opened a new pull request #1421: Add support for certificate and static 
token authentication to the Kubernetes driver
URL: https://github.com/apache/libcloud/pull/1421
 
 
   This pull request updates Kubernetes container driver so it now also 
supports client side certificate and static bearer token authentication
   
   ## Background
   
   Previously the driver only supported HTTP basic auth which is now deprecated.
   
   ## Implementation Details
   
   Most of the code for handling various types of authentication mechanism was 
already there (either available in the Kubernetes container driver or the 
KubeVirt compute one),
   this PR just updates it to make it more re-usable.
   
   This way we avoid duplicated (copy and pasted) code and re-use those base 
connection classes by both of the Kubernetes driver.
   
   ## Testing
   
   I tested the Kubernetes container driver and KubeVirt compute driver against 
a local minikube deployment.
   
   It probably wouldn't hurt if KubeVirt one gets more testing (cc @Eis-D-Z).
   
   On that note, for compliance with the base API (I missed that during the 
review), ``token_bearer_auth`` KubeVirt driver constructor argument has been 
renamed to ``ex_token_bearer_auth``.
   
   ## TODO
   
   - [ ] Refactor auth classes tests and also use them with the KubeVirt 
compute driver tests

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to