Kami commented on a change in pull request #1494:
URL: https://github.com/apache/libcloud/pull/1494#discussion_r495562822
##########
File path: libcloud/compute/drivers/ovh.py
##########
@@ -44,7 +44,8 @@ class OvhNodeDriver(NodeDriver):
VOLUME_STATE_MAP = OpenStackNodeDriver.VOLUME_STATE_MAP
SNAPSHOT_STATE_MAP = OpenStackNodeDriver.SNAPSHOT_STATE_MAP
- def __init__(self, key, secret, ex_project_id, ex_consumer_key=None):
+ def __init__(self, key, secret, ex_project_id, ex_consumer_key=None,
+ ex_datacenter=None):
Review comment:
For consistency and compatibility with other drivers which, you should
use existing ``region`` argument - AWS and many other drivers which support
multiple regions / datacenters support that argument.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
