Kami opened a new pull request #1531: URL: https://github.com/apache/libcloud/pull/1531
This pull request adds a workaround / fix for the issue reported in #1529. ## Background, Context It appears that in the past Libcloud supported URL paths with double slashes (e.g. ``/my-bucket/foo//1.txt``), but once moving to requests we added some code for path sanitization so we don't support that use case anymore. It appears that change was originally added in - fedace00261bcbb0a45bda003b968101a897d4ed. From technical perspective, I think it should be fine to support double slashes since that's usually handled / stripped on the server side (e.g. either inside the web server or inside the app), but I'm sure there was a valid reason for that change - with so many providers we support we've seen all kind of weird API issues and implementation so I assume that change was added to guard against such issues. ## Proposed Fix / Solution I tried a couple of things as a possible fix / workaround. It seems like that doing no path sanitization brakes a whole lot of other things so in the end I decided to go with a module level variable which can be changed by the user. This should be much safer change since it won't affect anyone but users who explicitly opt-in. I've done some testing and it appears to be working correctly end to end, but there could potentially still be edge cases hiding in the other parts of the code base. ## TODO - [ ] Upgrade notes entry - [ ] Documentation entry (S3 driver) Resolves #1529 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
