Kami commented on issue #1545:
URL: https://github.com/apache/libcloud/issues/1545#issuecomment-765315563


   Thanks for reporting this.
   
   Quickly glancing at this code, I don't see how it could affect it, but I 
need to dig in.
   
   Looking at the code it seems like we default to signature version 2. Did we 
ever default to version 4?
   
   * 
https://github.com/apache/libcloud/blob/trunk/libcloud/compute/drivers/ec2.py#L1618
   * https://github.com/apache/libcloud/blob/trunk/libcloud/common/aws.py#L54
   
   It seems like we only force version 4 if token auth is used - 
https://github.com/apache/libcloud/blob/trunk/libcloud/compute/drivers/ec2.py#L4696.
   
   I wonder if this could actually be related to AWS finally deprecating 
signature v2 for some of those regions 
(https://aws.amazon.com/blogs/aws/amazon-s3-update-sigv2-deprecation-period-extended-modified/)?
   
   If that's the case, it may make sense to default to v4 for everything, but 
we need to make sure it don't break anything.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to