c-w commented on a change in pull request #1580: URL: https://github.com/apache/libcloud/pull/1580#discussion_r628638877
########## File path: integration/storage/test_s3.py ########## @@ -0,0 +1,78 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the 'License'); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an 'AS IS' BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +import os +import sys +import unittest + +try: + import boto3 +except ImportError: + boto3 = None + +from integration.storage.base import Integration +from libcloud.storage import types + + +class S3Test(Integration.TestBase): + provider = 's3' + + @classmethod + def setUpClass(cls): + if boto3 is None: + raise unittest.SkipTest('missing boto3 library') + + config = { + key: os.getenv(key) + for key in ( + 'AWS_ACCESS_KEY_ID', + 'AWS_ACCESS_KEY_SECRET', + ) + } + + for key, value in config.items(): + if not value: + raise unittest.SkipTest('missing environment variable %s' % key) + + cls.account = config['AWS_ACCESS_KEY_ID'] + cls.secret = config['AWS_ACCESS_KEY_SECRET'] + + @classmethod + def tearDownClass(cls): + client = boto3.Session( Review comment: I figured that if we have a bug/regression in libcloud, we don't want to keep stray resources around so might as well use the official library to perform the cleanup. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
