Kami commented on pull request #1602: URL: https://github.com/apache/libcloud/pull/1602#issuecomment-949418409
Thanks for the contribution. I added some comments - I believe those changes may also affect Linux targets which is likely not what we want. Ideally there would also be some unit tests to begin with. I know we had some Windows target deployment related issues in the past, but I also know we have deployment stuff being used on Windows targets without any issues so it's likely some edge case which current code is not correctly handling. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
