Kami commented on pull request #1599: URL: https://github.com/apache/libcloud/pull/1599#issuecomment-1024687462
@ckarageorgkaneen @d-mo I see the diff is quite large - are all the changes backward incompatible (I'm talking mostly about the changes to the common Google and AWS connection code). And how should we approach reviewing and merging this? Are the changes already ready for a review or are they still WIP? In ideal world, those changes would be split into multiple PRs, but I know that would mean more work on your side, re-organizing all those changes. So if we are confident about the tests coverage and all the changes being backward compatible, we can also try to review it in the current form :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
