KatiRG opened a new pull request, #1712: URL: https://github.com/apache/libcloud/pull/1712
## Dynamically assign scheme to HTTP requests in azure driver ### Description Per #1703. The hard-coded `http` scheme is replaced with a variable that assigns it to `http` or `https` based on the value of `self.secure`. Otherwise, requests made to a secure Azure blob storage will always start with `http` and will fail, as this is not allowed. ### Status - done, ready for review ### Checklist (tick everything that applies) - [ ] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks) - [ ] Documentation - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html) - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes) Output of `tox`: ``` ========================================== 25 passed, 39 skipped in 13.11s =========================================== ______________________________________________________ summary _______________________________________________________ ERROR: pypypy3: InterpreterNotFound: pypy3 ERROR: py3.6: InterpreterNotFound: python3.6 ERROR: py3.7: InterpreterNotFound: python3.7 ERROR: py3.8: could not install deps [-r/home/ckan29lts/FORKS/libcloud/requirements-tests.txt, fasteners, libvirt-python==7.9.0]; v = InvocationError('/home/ckan29lts/FORKS/libcloud/.tox/py3.8/bin/python -m pip install -r/home/ckan29lts/FORKS/libcloud/requirements-tests.txt fasteners libvirt-python==7.9.0', 1) ERROR: py3.9: InterpreterNotFound: python3.9 ERROR: py3.10: InterpreterNotFound: python3.10 ERROR: pypyjion: InterpreterNotFound: pyjion ERROR: checks: InterpreterNotFound: python3.7 ERROR: lint: InterpreterNotFound: python3.7 ERROR: pylint: InterpreterNotFound: python3.7 ERROR: mypy: InterpreterNotFound: python3.7 ERROR: docs: InterpreterNotFound: python3.7 ERROR: coverage: InterpreterNotFound: python3.7 integration-storage: commands succeeded ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@libcloud.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
