shengwubin commented on code in PR #1796:
URL: https://github.com/apache/libcloud/pull/1796#discussion_r1064235523
##########
libcloud/common/base.py:
##########
@@ -527,6 +527,7 @@ def request(
stream=False,
json=None,
retry_failed=None,
+ container=None,
Review Comment:
The reason I changed this line is to avoid influencing other storage
providers, for example, s3.
My previous changes were not a good idea because they added several lines
into `libcloud/storage/base.py` so that other providers' upload functions will
throw exceptions.
I have reverted all the changes that lead to this situation, and the new
solution will only affect `libcloud/storage/drivers/oss.py`. The possible side
effect is that if the method `_upload_object` of class `StorageDriver` in
`libcloud/storage/base.py` changes, the OSS-related method also needs to be
changed if necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
