Kami commented on code in PR #1850:
URL: https://github.com/apache/libcloud/pull/1850#discussion_r1279288354
##########
libcloud/compute/drivers/azure_arm.py:
##########
@@ -468,11 +468,17 @@ def list_nodes(self, ex_resource_group=None,
ex_fetch_nic=True, ex_fetch_power_s
action = "/subscriptions/%s/providers/Microsoft.Compute/"
"virtualMachines" % (
self.subscription_id
)
- r = self.connection.request(action, params={"api-version":
VM_API_VERSION})
- return [
- self._to_node(n, fetch_nic=ex_fetch_nic,
fetch_power_state=ex_fetch_power_state)
- for n in r.object["value"]
- ]
+ params = {"api-version": VM_API_VERSION}
+ nodes = []
+ while True:
Review Comment:
I think this code is far for now, but to be on the safe side and avoid
possible infinite loop, I think it would be good to add additional guard here -
e.g. bail out if we are still stuck in this loop for more than X seconds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
