Kami commented on code in PR #1891:
URL: https://github.com/apache/libcloud/pull/1891#discussion_r1279664029
##########
libcloud/compute/drivers/azure_arm.py:
##########
@@ -1008,11 +1008,17 @@ def list_volumes(self, ex_resource_group=None):
action = action.format(
subscription_id=self.subscription_id,
resource_group=ex_resource_group
)
-
- response = self.connection.request(
- action, method="GET", params={"api-version": DISK_API_VERSION}
- )
- return [self._to_volume(volume) for volume in response.object["value"]]
+ params = {"api-version": DISK_API_VERSION}
Review Comment:
Since similar code is duplicated in two places, it would be nice to refactor
common functionality into a utility function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
