Kami commented on code in PR #2016:
URL: https://github.com/apache/libcloud/pull/2016#discussion_r1641747063
##########
libcloud/compute/drivers/openstack.py:
##########
@@ -3160,6 +3160,12 @@ def _to_network(self, obj):
extra["router:external"] = obj.get("router:external")
if obj.get("subnets", None):
extra["subnets"] = obj.get("subnets")
+ if obj.get("tags", None):
Review Comment:
Per codecov comment
(https://github.com/apache/libcloud/pull/2016#issuecomment-2154326853) could
you please add additional test cases so all the new code paths are covered?
This includes tests for all those fields being present and not being present
(so both the explicit "if" and implicit "else" code branches are covered).
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
