Arkelenia opened a new pull request, #2060:
URL: https://github.com/apache/libcloud/pull/2060

   ## Use the fully-qualified name for the GCP IMDS endpoint
   
   ### Description
   
   This PR replaces the current IMDS endpoint 
`http://metadata/computeMetadata/v1/...` with the fully-qualified name version 
`http://metadata.google.internal/computeMetadata/v1/...`.
   
   The current state assumes the presence of `google.internal` as a search 
domain to work properly which may not be the case when the endpoint is resolved 
from a container or a Kubernetes pod running on a GCP node.
   
   ### Status
   
   ready for review
   
   ### Checklist (tick everything that applies)
   
   - [ ] [Code 
linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
 (required, can be done after the PR checks)
   - [ ] Documentation
   - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
   - [ ] 
[ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
 (required for bigger changes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to