Sanjays2402 opened a new pull request, #2168: URL: https://github.com/apache/libcloud/pull/2168
Closes #1798 ### Description `download_object_as_stream` and `download_object_range_as_stream` in the S3 driver passed the hardcoded module-level `CHUNK_SIZE` to `response.iter_content()` instead of the `chunk_size` given by the caller, so a user-specified chunk size was silently ignored. They now forward `chunk_size` (falling back to `CHUNK_SIZE`), matching the backblaze_b2 and cloudfiles drivers. Added a regression test. ### Status - done, ready for review ### Checklist (tick everything that applies) - [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks) - [x] Documentation - [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
