Sanjays2402 opened a new pull request, #2173: URL: https://github.com/apache/libcloud/pull/2173
## [DigitalOcean] Include IPv6 addresses in node public/private IPs ### Description Closes #1738 `DigitalOcean_v2_NodeDriver._to_node()` only iterated the `v4` networks list, so a droplet's public IPv6 address was never reported in `Node.public_ips`. Each match also reassigned the list (`public_ips = [...]`) instead of appending, so only the last address of a given type survived. Both lists are now iterated and addresses appended. This matches the patch proposed in the issue. Note that the existing `list_nodes` fixture already contains a public IPv6 address (`2604:a880:4:1d0::142:9000`) that was being silently dropped, so `test_list_nodes_success` was updated to assert it. ### Status done, ready for review ### Checklist (tick everything that applies) - [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks) - [ ] Documentation - [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html) - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
