The GitHub Actions job "CI" on libcloud.git/fix/dns-response-shared-lists has 
failed.
Run started by GitHub user Hisernberg (triggered by micafer).

Head commit for run:
5dc1c7e1237c38d6bd82444b26526e0a61b93ad7 / Hisernberg 
<[email protected]>
Fix shared class-level errors/objects lists in DNS response classes

BuddyNSResponse, DNSPodResponse, LuadnsResponse and NsOneResponse
declared errors/objects as class-level mutable attributes and appended
to them from parse_body_and_errors(). The lists were shared by every
response object in the process, so parsed objects accumulated across
requests: a get_zone() reading response.objects[0] could receive data
from an earlier response, and errors leaked between requests.

Initialize fresh per-instance lists before super().__init__() (the base
Response constructor calls success(), which reads errors), and convert
the class attributes to bare annotations.

Regression tests added to all four driver test suites: with the old
code they fail (4 failures, 1 error); with this change all 60 tests in
the four suites pass.

Report URL: https://github.com/apache/libcloud/actions/runs/43029162028

With regards,
GitHub Actions via GitBox

Reply via email to