Hisernberg commented on PR #2216:
URL: https://github.com/apache/libcloud/pull/2216#issuecomment-6806674600

   Reconciliation analysis for the #2066 overlap (@aaron-sierra cc @micafer):
   
   The NsOneResponse hunks in #2066 and here are **semantically identical** — 
both move `errors`/`objects` from class attributes to per-instance lists 
assigned *before* `super().__init__()` (which matters: `JsonResponse.__init__` 
calls `success()`, which reads `self.errors`), then reassign them from 
`parse_body_and_errors()`. This PR additionally annotates the attributes, 
documents the ordering constraint, applies the same fix to 
BuddyNS/DNSPod/LuaDNS, and pins the behavior with regression tests 
(`test_errors_do_not_leak_across_responses`, 
`test_objects_do_not_accumulate_across_responses` in 
`libcloud/test/dns/test_nsone.py`).
   
   So whichever PR merges first, the other rebases with at most a same-content 
conflict — no behavioral decision is needed. If #2066 lands first, its 
NsOneResponse hunk can simply be dropped in favor of this one (the regression 
tests here still apply unchanged).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to