JunaidAhamed-7777 opened a new issue, #2223: URL: https://github.com/apache/libcloud/issues/2223
On trunk [`8a0ef626`](https://github.com/apache/libcloud/commit/8a0ef6260680625d54fce5093d2315e0926a7dc9), the local driver's range-download method creates a destination file but does not clean it up when opening the source fails, even with `delete_on_failure=True`. This reproducer is sequential: obtain the object metadata, explicitly remove the stored file, then try to download. It does not depend on winning a filesystem race. ```python import os import tempfile from libcloud.storage.drivers.local import LocalStorageDriver with tempfile.TemporaryDirectory() as root: driver = LocalStorageDriver(root) container = driver.create_container("bucket") obj = driver.upload_object_via_stream(iter([b"payload"]), container, "object") os.unlink(driver.get_object_cdn_url(obj)) destination = os.path.join(root, "download") try: driver.download_object_range( obj, destination, start_bytes=0, delete_on_failure=True ) except FileNotFoundError: pass print(os.path.exists(destination), os.path.getsize(destination)) # True 0 ``` The [public range-download contract](https://github.com/apache/libcloud/blob/8a0ef6260680625d54fce5093d2315e0926a7dc9/libcloud/storage/base.py#L489-L536) describes `delete_on_failure` as deleting a partially downloaded file when the download was unsuccessful, with hash mismatch/file size given as examples. I expected the newly created empty output to be removed for a source-read failure as well. Otherwise a failed operation leaves a file that can be mistaken for a valid empty download. The [local implementation](https://github.com/apache/libcloud/blob/8a0ef6260680625d54fce5093d2315e0926a7dc9/libcloud/storage/drivers/local.py#L480-L511) accepts the flag but never reads it. It opens the destination before consuming the source iterator and has no failure cleanup around that loop. Checks with unchanged source, Python 3.12/Linux: - Range download with `delete_on_failure=True`: raises `FileNotFoundError`, leaves a zero-byte output. - Range download with `delete_on_failure=False`: same result. - Full `download_object` with the same missing source: returns `False`, leaves no output. - Successful range `[0, 3)` before removing the source: returns `True`, writes `b"pay"`. No code change yet. This report is limited to failure cleanup for local range downloads; it does not claim a concurrent-write reproduction or a full test-suite pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
