jackxu2011 commented on code in PR #4110:
URL: https://github.com/apache/linkis/pull/4110#discussion_r1093242093
##########
linkis-engineconn-plugins/spark/pom.xml:
##########
@@ -418,6 +454,18 @@
</exclusion>
</exclusions>
</dependency>
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-common</artifactId>
+ <version>${hadoop-hdfs-client-shade.version}</version>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>${hadoop-hdfs-client-shade.artifact}</artifactId>
+ <version>${hadoop-hdfs-client-shade.version}</version>
Review Comment:
can there remove the version property? or use ${hadoop.version}
##########
linkis-engineconn-plugins/shell/pom.xml:
##########
@@ -111,6 +111,10 @@
<scope>provided</scope>
</dependency>
+ <dependency>
+ <groupId>org.eclipse.jetty</groupId>
+ <artifactId>jetty-client</artifactId>
+ </dependency>
Review Comment:
this dependency can be removed
##########
linkis-engineconn-plugins/spark/pom.xml:
##########
@@ -418,6 +454,18 @@
</exclusion>
</exclusions>
</dependency>
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-common</artifactId>
+ <version>${hadoop-hdfs-client-shade.version}</version>
Review Comment:
can there remove the version property? , or use ${hadoop.version}
##########
linkis-engineconn-plugins/spark/pom.xml:
##########
@@ -140,6 +140,11 @@
</exclusions>
</dependency>
+ <dependency>
+ <groupId>org.eclipse.jetty</groupId>
+ <artifactId>jetty-client</artifactId>
+ </dependency>
Review Comment:
this dependency can be removed
##########
linkis-engineconn-plugins/python/pom.xml:
##########
@@ -67,6 +67,11 @@
<scope>provided</scope>
</dependency>
+ <dependency>
+ <groupId>org.eclipse.jetty</groupId>
+ <artifactId>jetty-client</artifactId>
+ </dependency>
Review Comment:
this dependency can be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
