jackxu2011 commented on code in PR #4439:
URL: https://github.com/apache/linkis/pull/4439#discussion_r1156836821
##########
linkis-commons/linkis-module/pom.xml:
##########
@@ -361,20 +361,20 @@
</exclusions>
</dependency>
- <dependency>
- <groupId>com.sun.jersey</groupId>
- <artifactId>jersey-json</artifactId>
- <exclusions>
- <exclusion>
- <groupId>javax.ws.rs</groupId>
- <artifactId>jsr311-api</artifactId>
- </exclusion>
- <exclusion>
- <groupId>com.sun.jersey</groupId>
- <artifactId>jersey-core</artifactId>
- </exclusion>
- </exclusions>
- </dependency>
+ <!-- <dependency>-->
+ <!-- <groupId>com.sun.jersey</groupId>-->
+ <!-- <artifactId>jersey-json</artifactId>-->
+ <!-- <exclusions>-->
+ <!-- <exclusion>-->
+ <!-- <groupId>javax.ws.rs</groupId>-->
+ <!-- <artifactId>jsr311-api</artifactId>-->
+ <!-- </exclusion>-->
+ <!-- <exclusion>-->
+ <!-- <groupId>com.sun.jersey</groupId>-->
+ <!-- <artifactId>jersey-core</artifactId>-->
+ <!-- </exclusion>-->
+ <!-- </exclusions>-->
+ <!-- </dependency>-->
Review Comment:
just remove the dependencies
##########
pom.xml:
##########
@@ -414,36 +414,36 @@
<version>${json4s.version}</version>
</dependency>
- <dependency>
- <groupId>com.sun.jersey</groupId>
- <artifactId>jersey-client</artifactId>
- <version>${jersey.version}</version>
- </dependency>
- <dependency>
- <groupId>com.sun.jersey</groupId>
- <artifactId>jersey-server</artifactId>
- <version>${jersey.version}</version>
- </dependency>
- <dependency>
- <groupId>com.sun.jersey</groupId>
- <artifactId>jersey-servlet</artifactId>
- <version>${jersey.version}</version>
- </dependency>
- <dependency>
- <groupId>com.sun.jersey</groupId>
- <artifactId>jersey-core</artifactId>
- <version>${jersey.version}</version>
- </dependency>
- <dependency>
- <groupId>com.sun.jersey</groupId>
- <artifactId>jersey-json</artifactId>
- <version>${jersey.version}</version>
- </dependency>
- <dependency>
- <groupId>com.sun.jersey.contribs</groupId>
- <artifactId>jersey-guice</artifactId>
- <version>${jersey.version}</version>
- </dependency>
Review Comment:
this lines can't be deleted, the eureka server is still use
##########
linkis-commons/linkis-module/pom.xml:
##########
@@ -328,24 +328,24 @@
<version>1.4</version>
</dependency>
- <dependency>
- <groupId>com.sun.jersey</groupId>
- <artifactId>jersey-server</artifactId>
- <exclusions>
- <exclusion>
- <groupId>javax.ws.rs</groupId>
- <artifactId>jsr311-api</artifactId>
- </exclusion>
- <exclusion>
- <groupId>javax.validation</groupId>
- <artifactId>validation-api</artifactId>
- </exclusion>
- </exclusions>
- </dependency>
- <dependency>
- <groupId>com.sun.jersey</groupId>
- <artifactId>jersey-servlet</artifactId>
- </dependency>
+ <!-- <dependency>-->
+ <!-- <groupId>com.sun.jersey</groupId>-->
+ <!-- <artifactId>jersey-server</artifactId>-->
+ <!-- <exclusions>-->
+ <!-- <exclusion>-->
+ <!-- <groupId>javax.ws.rs</groupId>-->
+ <!-- <artifactId>jsr311-api</artifactId>-->
+ <!-- </exclusion>-->
+ <!-- <exclusion>-->
+ <!-- <groupId>javax.validation</groupId>-->
+ <!-- <artifactId>validation-api</artifactId>-->
+ <!-- </exclusion>-->
+ <!-- </exclusions>-->
+ <!-- </dependency>-->
+ <!-- <dependency>-->
+ <!-- <groupId>com.sun.jersey</groupId>-->
+ <!-- <artifactId>jersey-servlet</artifactId>-->
+ <!-- </dependency>-->
Review Comment:
just remove the lines
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@linkis.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@linkis.apache.org
For additional commands, e-mail: notifications-h...@linkis.apache.org
