[GitHub] [linkis] ChengJie1053 commented on a diff in pull request #4449: ECM code optimization

[via GitHub]

ChengJie1053 commented on code in PR #4449:
URL: https://github.com/apache/linkis/pull/4449#discussion_r1161084267


##########
linkis-computation-governance/linkis-computation-governance-common/src/main/scala/org/apache/linkis/governance/common/utils/ECPathUtils.scala:
##########
@@ -25,24 +25,16 @@ import java.nio.file.Paths
 
 object ECPathUtils {
 
-  def getECWOrkDirPathSuffix(
-      user: String,
-      ticketId: String,
-      engineType: String,
-      timeStamp: Long = System.currentTimeMillis()
-  ): String = {
-    val suffix = if (StringUtils.isBlank(engineType)) {
-      Paths
-        .get(user, DateFormatUtils.format(System.currentTimeMillis(), 
"yyyyMMdd"))
-        .toFile
-        .getPath
-    } else {
-      Paths
-        .get(user, DateFormatUtils.format(System.currentTimeMillis(), 
"yyyyMMdd"), engineType)
-        .toFile
-        .getPath
-    }
-    suffix + File.separator + ticketId
+  def getECWOrkDirPathSuffix(user: String, ticketId: String, engineType: 
String): String = {
+    Paths
+      .get(
+        user,
+        DateFormatUtils.format(System.currentTimeMillis(), "yyyyMMdd"),
+        if (StringUtils.isBlank(engineType)) "" else engineType

Review Comment:
   
![image](https://user-images.githubusercontent.com/125547374/230712146-49c4d63d-b489-45e4-986f-c3b14ee8409b.png)
   If empty skip
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@linkis.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@linkis.apache.org
For additional commands, e-mail: notifications-h...@linkis.apache.org