jackxu2011 commented on code in PR #4459: URL: https://github.com/apache/linkis/pull/4459#discussion_r1163484637
########## linkis-commons/linkis-storage/src/main/java/org/apache/linkis/storage/LineMetaData.java: ########## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.linkis.storage; + +import org.apache.linkis.common.io.MetaData; +import org.apache.linkis.storage.resultset.ResultMetaData; + +public class LineMetaData implements ResultMetaData { + + public String metaData = null; + + public LineMetaData() {} + + public LineMetaData(String metaData) { + this.metaData = metaData; + } + + public String getMetaData() { + return metaData; + } + + public void setMetaData(String metaData) { + this.metaData = metaData; + } + + public MetaData cloneMeta() { + return new LineMetaData(metaData); Review Comment: if the metaData need be cloned also? ########## pom.xml: ########## @@ -1362,10 +1363,10 @@ </execution> </executions> </plugin> - <plugin> - <groupId>com.diffplug.spotless</groupId> - <artifactId>spotless-maven-plugin</artifactId> - </plugin> + <!-- <plugin>--> + <!-- <groupId>com.diffplug.spotless</groupId>--> + <!-- <artifactId>spotless-maven-plugin</artifactId>--> + <!-- </plugin>--> Review Comment: why remove the plugin? ########## linkis-commons/linkis-storage/src/main/java/org/apache/linkis/storage/LineRecord.java: ########## @@ -15,22 +15,33 @@ * limitations under the License. */ -package org.apache.linkis.storage.resultset.table +package org.apache.linkis.storage; -import org.apache.linkis.common.io.Record -import org.apache.linkis.storage.resultset.ResultRecord -import org.apache.linkis.storage.utils.StorageUtils +import org.apache.linkis.common.io.Record; +import org.apache.linkis.storage.resultset.ResultRecord; -class TableRecord(val row: Array[Any]) extends ResultRecord { +public class LineRecord implements ResultRecord { + public String line; - override def cloneRecord(): Record = { - new TableRecord(row) + public LineRecord(String line) { + this.line = line; } - def tableRecordToString(nullValue: String = "NULL"): Array[String] = { - row.map { col => - StorageUtils.colToString(col, nullValue) - } + public String getLine() { + return line; } + public void setLine(String line) { + this.line = line; + } + + @Override + public Record cloneRecord() { + return new LineRecord(line); Review Comment: if the line need be cloned also? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@linkis.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@linkis.apache.org For additional commands, e-mail: notifications-h...@linkis.apache.org
