CharlieYan24 commented on code in PR #4459:
URL: https://github.com/apache/linkis/pull/4459#discussion_r1169425248
##########
linkis-commons/linkis-storage/src/main/java/org/apache/linkis/storage/excel/ExcelXlsReader.java:
##########
@@ -258,13 +263,15 @@ public void close() {
if (fs != null) {
fs.close();
}
- if (inputStream != null) {
- inputStream.close();
+ try {
+ if (inputStream != null) {
+ inputStream.close();
+ }
+ } catch (IOException e) {
+ logger.info("ExcelXlsReader inputStream closed failed", e);
Review Comment:
Already separated try catch block of ExeclXlsReader.close() method , so
that if the fs.close() throws exception, the close method of inputStream will
continue to execute. Thanks for your good advice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@linkis.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@linkis.apache.org
For additional commands, e-mail: notifications-h...@linkis.apache.org
