[
https://issues.apache.org/jira/browse/LOG4J2-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16245647#comment-16245647
]
ASF GitHub Bot commented on LOG4J2-2110:
----------------------------------------
GitHub user thomasbeauvais opened a pull request:
https://github.com/apache/logging-log4j2/pull/128
LOG4J2-2110 adding a ServletContext parameter to allow the contextIni…
Please refer to https://issues.apache.org/jira/browse/LOG4J2-2110
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/thomasbeauvais/logging-log4j2 master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/logging-log4j2/pull/128.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #128
----
commit cb0e2020b6106431a53dea497ca8415b1567b2c1
Author: itonics-tbeauvais <[email protected]>
Date: 2017-11-09T13:30:43Z
LOG4J2-2110 adding a ServletContext parameter to allow the
contextInitialized to be skipped and still work in the contextDestroyed
----
> Log4jServletContextListener skips initialization and thusly never calls stop()
> ------------------------------------------------------------------------------
>
> Key: LOG4J2-2110
> URL: https://issues.apache.org/jira/browse/LOG4J2-2110
> Project: Log4j 2
> Issue Type: Bug
> Components: Web/Servlet
> Affects Versions: 2.8, 2.8.1, 2.8.2, 2.9.0, 2.9.1
> Reporter: Thomas Beauvais
> Priority: Critical
>
> {{Log4jServletContextListener}} is not working in Tomcat 8 or 8.5 as it's
> never initialized.
> The {{contextInitialized}} is never called and thus it never sets the
> {{servletContext}}.
> This is checked when a {{servletContext}} is destroyed and ignored every time.
> The outcome, is that our customer appenders are never stopped leading to
> resource leaks.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
