[
https://issues.apache.org/jira/browse/LOG4J2-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16246566#comment-16246566
]
Frank Swanson commented on LOG4J2-2072:
---------------------------------------
[[email protected]] That makes sense, totally. if you are changing a
public interface. I would agree whole heartedly that if the public interface
needed to change then that public interface would need to change to use the
builder pattern. 100%. I would even say that in that case this should
absolutely happen first.
For this update there is no change to the public interface for the appender
only the internals. While the manager does need to change this is not a class
that is intended to be used directly.
I am happy to take on the work of updating the interface too. As that is a nice
to have ... and I would like to update my code to work that way too. But what i
have done already and care about is that the code is working. Furthermore I
could see a lot of discussion about how to update etc ... its very opinion
based. the fact that code is broken today and easily fixable with a small
update is irrefutable. I would love to fix the code so it can work in
production.
> Support TLS configuration through FlumeAppender
> -----------------------------------------------
>
> Key: LOG4J2-2072
> URL: https://issues.apache.org/jira/browse/LOG4J2-2072
> Project: Log4j 2
> Issue Type: Bug
> Components: Flume Appender
> Affects Versions: 2.9.1
> Reporter: Frank Swanson
>
> When using the FlumeAppnder with a FlumeAvroManager it would be nice to be
> able to pass some properties through to the connect method for the RpcClient
> to support SSL configuration.
> The required properties to support the configuration are ~
> properties[0] =
> Property.createProperty(RpcClientConfigurationConstants.CONFIG_TRUST_ALL_CERTS,
> "false");
> properties[1] =
> Property.createProperty(RpcClientConfigurationConstants.CONFIG_SSL, "true");
> properties[2] =
> Property.createProperty(RpcClientConfigurationConstants.CONFIG_TRUSTSTORE,
> path_to_truststore);
> properties[3] =
> Property.createProperty(RpcClientConfigurationConstants.CONFIG_TRUSTSTORE_PASSWORD,
> super_secret);
> properties[4] =
> Property.createProperty(RpcClientConfigurationConstants.CONFIG_TRUSTSTORE_TYPE,
> "JKS");
> I am happy to provide a PR for this feature if supported.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
