[
https://issues.apache.org/jira/browse/LOG4J2-2177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16314221#comment-16314221
]
Remko Popma edited comment on LOG4J2-2177 at 1/6/18 3:39 AM:
-------------------------------------------------------------
My objective was to keep the design flexible so we have the freedom to change
the implementation later. {{StringMap}} is much easier to re-implement than
{{IndexedStringMap}}.
I’m still unclear about what the concern is. What problem would be solved by
changing the return value of {{ContextDataFactory}} from {{StringMap}} to
{{IndexedStringMap}}? Is there a type cast somewhere that could be avoided by
this or is there something else?
was (Author: [email protected]):
My objective was to keep the design flexible so we have the freedom to change
the implementation later. {{StringMap}} is much easier to re-implement than
{{IndexedStringMap}}.
You haven’t explained what your concern is. What problem are you trying to
solve by changing the return value of {{ContextDataFactory}} from
{{StringMap}} to {{IndexedStringMap}}? Are you trying to avoid a type cast
somewhere or is there something else?
> Replace use of deprecated Core API
> org.apache.logging.log4j.core.impl.Log4jLogEvent.Builder.setContextMap(Map<String,
> String>)
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: LOG4J2-2177
> URL: https://issues.apache.org/jira/browse/LOG4J2-2177
> Project: Log4j 2
> Issue Type: Improvement
> Components: Core
> Affects Versions: 2.10.0
> Reporter: Gary Gregory
> Assignee: Gary Gregory
>
> Replace use of deprecated Core API
> {{org.apache.logging.log4j.core.impl.Log4jLogEvent.Builder.setContextMap(Map<String,
> String>)}}
> In order to implement this cleanly, the internal class
> {{org.apache.logging.log4j.core.impl.ContextDataFactory}} will change its API
> return values from {{StringMap}} to {{IndexedStringMap}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
