[ 
https://issues.apache.org/jira/browse/LOG4J2-2177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317655#comment-16317655
 ] 

Gary Gregory commented on LOG4J2-2177:
--------------------------------------

Hi [[email protected]], yes of course. I did not know it was going to be so 
touchy when I started but I also am glad it went the way it did because:
- Doing it as a patch or branch would have been harder to review due to the 
amount lines touched. Changes seemed to have trickled.
- Doing it as I did gave me at least the urgency to adjust the solution 
quickly. It was nice to get the ebb and flow of changes happen, be reviewed and 
adjusted.
Note that I would have not let a release vote go through without this being on 
everyone's radar, but now I believe we are in better shape :-)

Thank you all of the review and suggestions (and keeping me on my toes :-)

> Replace use of deprecated Core API 
> org.apache.logging.log4j.core.impl.Log4jLogEvent.Builder.setContextMap(Map<String,
>  String>)
> ------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: LOG4J2-2177
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-2177
>             Project: Log4j 2
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 2.10.0
>            Reporter: Gary Gregory
>            Assignee: Gary Gregory
>
> Replace use of deprecated Core API 
> {{org.apache.logging.log4j.core.impl.Log4jLogEvent.Builder.setContextMap(Map<String,
>  String>)}}
> In order to implement this cleanly, the internal class 
> {{org.apache.logging.log4j.core.impl.ContextDataFactory}} will change its API 
> return values from {{StringMap}} to {{IndexedStringMap}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to