[ 
https://issues.apache.org/jira/browse/LOG4J2-2212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Feist updated LOG4J2-2212:
---------------------------------
    Description: 
The following method retrieves the value of a system property for each and 
every map that is created.  While maps are cached/reused where possible via 
thread local this method is still used a lot in runtime.

{{protected StringMap createStringMap() {}}
 {{return new 
SortedArrayStringMap(PropertiesUtil.getProperties().getIntegerProperty(}}
 {{PROPERTY_NAME_INITIAL_CAPACITY, DEFAULT_INITIAL_CAPACITY));}}
 {{}}}

Under concurrency, this introduces unnecessary contention due to 
java.util.Properties monitor in HashTable.contains when retrieving system 
property, as seen below.

!Screen Shot 2018-01-23 at 14.23.33.png! 
 

 

  was:
The following method retrieves the value of a system property for each and 
every map that is created.  While maps are cached/reused where possible via 
thread local this method is still used a lot in runtime.

{{protected StringMap createStringMap() {}}
{{return new 
SortedArrayStringMap(PropertiesUtil.getProperties().getIntegerProperty(}}
{{PROPERTY_NAME_INITIAL_CAPACITY, DEFAULT_INITIAL_CAPACITY));}}
{{}}}

Under concurrency, this introduces unnecessary contention due to 
java.util.Properties monitor in HashTable.contains when retrieving system, 
property.

 

 


> Unnecessary contention in CopyOnWriteSortedArrayThreadContextMap
> ----------------------------------------------------------------
>
>                 Key: LOG4J2-2212
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-2212
>             Project: Log4j 2
>          Issue Type: Improvement
>    Affects Versions: 2.10.0
>            Reporter: Daniel Feist
>            Priority: Major
>         Attachments: Screen Shot 2018-01-23 at 14.23.33.png
>
>
> The following method retrieves the value of a system property for each and 
> every map that is created.  While maps are cached/reused where possible via 
> thread local this method is still used a lot in runtime.
> {{protected StringMap createStringMap() {}}
>  {{return new 
> SortedArrayStringMap(PropertiesUtil.getProperties().getIntegerProperty(}}
>  {{PROPERTY_NAME_INITIAL_CAPACITY, DEFAULT_INITIAL_CAPACITY));}}
>  {{}}}
> Under concurrency, this introduces unnecessary contention due to 
> java.util.Properties monitor in HashTable.contains when retrieving system 
> property, as seen below.
> !Screen Shot 2018-01-23 at 14.23.33.png! 
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to