[
https://issues.apache.org/jira/browse/LOG4NET-572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16338184#comment-16338184
]
Dominik Psenner commented on LOG4NET-572:
-----------------------------------------
Nicholas Perego just commented this on the original github pull request:
{quote}I don't think it's needed anymore with Neststandard 2.0 to modify the
file "log4net.Config.XmlConfigurator" like this :
[https://github.com/apache/logging-log4net/blob/master/src/Config/XmlConfigurator.cs#L164],
because in Netstandard 2.0 you can use "Assembly.GetCallingAssembly()".
As example, it's needed to use log4net with Common.Logging (see
[net-commons/common-logging#167|https://github.com/net-commons/common-logging/issues/167])
in ASP.NET Core 2.0.
I tried successfully to remove the "#if !NETSTANDARD1_3" of the file, recompile
and use the modified dll with Common.Logging and it works fine.
Maybe I'm missing something here, but it maybe is a good idea to revert this
change ? Thanx.. — Nicholas Perego
{quote}
This finding is very useful and we should consider #if NETSTANDARD2_0 when
building log4net against netstandard-2.0.
> Add target for netstandard-2.0
> ------------------------------
>
> Key: LOG4NET-572
> URL: https://issues.apache.org/jira/browse/LOG4NET-572
> Project: Log4net
> Issue Type: New Feature
> Components: Builds
> Reporter: Dominik Psenner
> Assignee: Dominik Psenner
> Priority: Major
>
> Currently all work done so far is available in branch
> feature/netstandard-2.0; the builds pass but CI currently cannot run the
> tests for the targets netstandard-1.3 and netstandard-2.0.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
