Github user garydgregory commented on the issue:

    https://github.com/apache/logging-log4j2/pull/144
  
    @wangzhongkuo: We are a volunteer-based organization, and as such, we look 
for as much help as we can as all of our schedules are busy, as is yours I 
imagine. This is why we ask for contributions and for contributors to ease the 
addition of new features and the inclusion of bug fixes by follow a fairly 
light process to minimize the impact of changes and of time in reviewing 
patches. 
    
    With this in mind, this PR contains no unit tests, and as such will likely 
not get accepted (by me at least.) Do consider:
    
    1. Write a unit test that FAILS, therefore demonstrating that there is a 
problem.
    2. Apply your bug fix
    3. Run the test again and it now PASSES, demonstrating that your fix works.
    4. Run all the unit tests to make sure your fix didn't break something else.
    
    Thank you,
    Gary


---

Reply via email to