[GitHub] logging-log4j2 pull request #148: LOG4J2-2252: Reusable LogEvents pass along...

[remkop]

Github user remkop commented on a diff in the pull request:

    https://github.com/apache/logging-log4j2/pull/148#discussion_r169575464
  
    --- Diff: 
log4j-api/src/main/java/org/apache/logging/log4j/message/ReusableSimpleMessage.java
 ---
    @@ -43,7 +43,7 @@ public String getFormattedMessage() {
     
         @Override
         public String getFormat() {
    -        return getFormattedMessage();
    +        return charSequence instanceof String ? (String) charSequence : 
null;
    --- End diff --
    
    This is wrong. If charSequence is a StringBuilder or CharBuffer, the method 
would return null after the proposed change.


---