[
https://issues.apache.org/jira/browse/LOG4J2-2322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16446380#comment-16446380
]
ASF GitHub Bot commented on LOG4J2-2322:
----------------------------------------
GitHub user cakofony opened a pull request:
https://github.com/apache/logging-log4j2/pull/170
[LOG4J2-2322] Custom async ContextSelectors disable location by default
AsyncLoggerContextSelector disables "includeLocation" on loggers
unless specified. Custom ContextSelector implementations will
trigger this logic as well.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cakofony/logging-log4j2 LOG4J2-2322
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/logging-log4j2/pull/170.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #170
----
commit 0c17e100a402c2d208bccbef6a02655be49945e1
Author: Carter Kozak <ckozak@...>
Date: 2018-04-20T20:31:51Z
[LOG4J2-2322] Custom async ContextSelectors disable location by default
AsyncLoggerContextSelector disables "includeLocation" on loggers
unless specified. Custom ContextSelector implementations will
trigger this logic as well.
----
> Custom Async ContextSelectors should disable location by default
> ----------------------------------------------------------------
>
> Key: LOG4J2-2322
> URL: https://issues.apache.org/jira/browse/LOG4J2-2322
> Project: Log4j 2
> Issue Type: Bug
> Components: Core
> Reporter: Carter Kozak
> Assignee: Carter Kozak
> Priority: Major
>
> When AsyncLoggerContextSelector is selected, we modify the default value of
> LoggerConfig.includeLocation from true to false.
> Custom asynchronous ContextSelector implementations should also trigger this
> logic to avoid unnecessarily work.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
