Github user cakofony commented on a diff in the pull request:
https://github.com/apache/logging-log4j2/pull/203#discussion_r208651767
--- Diff:
log4j-api/src/main/java/org/apache/logging/log4j/message/ReusableObjectMessage.java
---
@@ -100,16 +100,17 @@ public Throwable getThrowable() {
*/
@Override
public Object[] swapParameters(final Object[] emptyReplacement) {
+ emptyReplacement[0] = obj;
--- End diff --
I can't imagine that `emptyReplacement` should ever be empty, but it might
be worth doing something along these lines:
```java
if (emptyReplacement.length == 0) {
Object[] params = new Object[10]; // Default reusable parameter buffer
size
params[0] = obj;
return params;
}
emptyReplacement[0] = obj;
return emptyReplacement;
```
---
