[GitHub] logging-log4j2 pull request #205: [LOG4J2-2399] support for async formatting...

[bjlaub]

Github user bjlaub commented on a diff in the pull request:

    https://github.com/apache/logging-log4j2/pull/205#discussion_r208965807
  
    --- Diff: 
log4j-core/src/main/java/org/apache/logging/log4j/core/impl/MutableLogEvent.java
 ---
    @@ -204,15 +206,19 @@ public void setLoggerName(final String loggerName) {
         @Override
         public Message getMessage() {
             if (message == null) {
    -            return messageText == null ? EMPTY : this;
    +            return (messageText == null && messageContentFormatter == 
null) ? EMPTY : this;
             }
             return message;
         }
     
         public void setMessage(final Message msg) {
             if (msg instanceof ReusableMessage) {
                 final ReusableMessage reusable = (ReusableMessage) msg;
    -            reusable.formatTo(getMessageTextForWriting());
    +            if (Constants.FORMAT_MESSAGES_IN_BACKGROUND && msg instanceof 
MessageContentFormatterProvider) {
    +                this.messageContentFormatter = 
((MessageContentFormatterProvider) msg).getMessageContentFormatter();
    --- End diff --
    
    see 
https://github.com/apache/logging-log4j2/pull/208/commits/fc8ed21311d3a428b5a673a1b289ea2624e60cdb
 in #208 


---