[
https://issues.apache.org/jira/browse/LOG4J2-2443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16616732#comment-16616732
]
ASF GitHub Bot commented on LOG4J2-2443:
----------------------------------------
GitHub user andrei-ivanov opened a pull request:
https://github.com/apache/logging-log4j-audit/pull/4
[LOG4J2-2443]
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/andrei-ivanov/logging-log4j-audit LOG4J2-2443
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/logging-log4j-audit/pull/4.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4
----
commit 5c5c875d324898ea51d9a1797a34bf60e62c517c
Author: Andrei Ivanov <andrei.ivanov@...>
Date: 2018-09-16T13:03:32Z
[LOG4J2-2443] Remove unused exceptions
commit a27bd7642be15b41bbc5d63ddf17257f982623f3
Author: Andrei Ivanov <andrei.ivanov@...>
Date: 2018-09-16T13:14:40Z
[LOG4J2-2443] optimize imports
commit b3f088ef893921ffa42a2c9a6e6559a4cd3569cd
Author: Andrei Ivanov <andrei.ivanov@...>
Date: 2018-09-16T13:14:49Z
[LOG4J2-2443] Remove unused exception
commit 13f058151de0f6a45136073f347750c177cbbf54
Author: Andrei Ivanov <andrei.ivanov@...>
Date: 2018-09-16T13:17:31Z
[LOG4J2-2443] Remove unused exception, seems to be a duplicate of
CatalogModificationException
commit bf545f37122cd080d17278f8516e2091a04c75fa
Author: Andrei Ivanov <andrei.ivanov@...>
Date: 2018-09-16T13:31:09Z
[LOG4J2-2443] Consistent throwning of ConstraintValidationException for
valitation errors
commit 063c2580fac4975b3dc47c2a32a6763ae9379cc2
Author: Andrei Ivanov <andrei.ivanov@...>
Date: 2018-09-16T13:44:05Z
[LOG4J2-2443] move ConstraintValidationException in the log4j-audit-api
module as it's the only place it was used and make it extend AuditException
----
> Consistent validation exceptions
> --------------------------------
>
> Key: LOG4J2-2443
> URL: https://issues.apache.org/jira/browse/LOG4J2-2443
> Project: Log4j 2
> Issue Type: Improvement
> Components: Log4j-Audit
> Affects Versions: Log4j-Audit 1.0.0
> Reporter: Andrei Ivanov
> Priority: Major
>
> Trying to create an {{ExceptionMapper}} for the validation exceptions I
> notice that there are 2 kind of exceptions that are thrown when logging.
> {{AbstractEventLogger}} mostly throws {{AuditException}}, but there's even a
> {{IllegalStateException}} thrown, that probably can be changed to an
> {{AuditException}}.
> But then there's {{LogEventFactory}} that throws
> {{ConstraintValidationException}} for validation errors.
> I then thought there's an exception hierarchy in place, but it seems there's
> no relation between {{AuditException}} and {{ConstraintValidationException}}.
> Please consider making {{AbstractEventLogger}} also throw
> {{ConstraintValidationException}} and maybe create some hierarchy for these
> exceptions to provide them a common base exception, perhaps
> {{AuditException}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
