[
https://issues.apache.org/jira/browse/LOG4J2-2420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16617248#comment-16617248
]
ASF GitHub Bot commented on LOG4J2-2420:
----------------------------------------
GitHub user andrei-ivanov opened a pull request:
https://github.com/apache/logging-log4j-audit/pull/6
[LOG4J2-2420]
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/andrei-ivanov/logging-log4j-audit LOG4J2-2420
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/logging-log4j-audit/pull/6.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6
----
commit 390cbe9798a617eafc7102ecd629da8ea4751266
Author: Andrei Ivanov <andrei.ivanov@...>
Date: 2018-09-17T08:32:48Z
[LOG4J2-2420] fix parameter logging
commit e333cda808ffd3472477bdf48c119fcf256d3970
Author: Andrei Ivanov <andrei.ivanov@...>
Date: 2018-09-17T08:41:42Z
[LOG4J2-2420] switch the logging of request processing duration to TRACE
level
----
> RequestContextFilter logging cleanup
> ------------------------------------
>
> Key: LOG4J2-2420
> URL: https://issues.apache.org/jira/browse/LOG4J2-2420
> Project: Log4j 2
> Issue Type: Improvement
> Components: Log4j-Audit
> Affects Versions: Log4j-Audit 1.0.0
> Reporter: Andrei Ivanov
> Priority: Minor
>
> The {{RequestContextFilter}} logs some details that should be done on
> {{DEBUG}} or {{TRACE}} instead of {{INFO}}.
> {noformat}
> INFO [org.apache.logging.log4j.audit.rest.RequestContextFilter] - Starting
> request {}/productrepository/2594
> INFO [org.apache.logging.log4j.audit.rest.RequestContextFilter] - Request
> /productrepository/2594 completed in 0.139279500 seconds
> {noformat}
> There's even a small bug on the 1st
> [line|https://github.com/apache/logging-log4j-audit/blob/9bab5dad26e67642573cbc8257b6cbcafb23bf3c/log4j-audit/log4j-audit-api/src/main/java/org/apache/logging/log4j/audit/rest/RequestContextFilter.java#L82]
> where concatenation was used.
> The calculation of the request duration should also be moved in an if block,
> to avoid it if it won't be logged.
> Same for the Maven plugin, I think it should print the name of the generated
> classes only on debug.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
