[ 
https://issues.apache.org/jira/browse/LOG4J2-2454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16629730#comment-16629730
 ] 

Ralph Goers edited comment on LOG4J2-2454 at 9/27/18 4:14 AM:
--------------------------------------------------------------

The purpose of a filter is to decide whether an event should be logged. Your 
Alarm filter doesn't seem to be for that purpose as it doesn't even have 
onMatch or onMismatch attributes. Since the purpose of a filter is to allow an 
event through or block it, it doesn't make sense for a filter's attributes to 
be passed to anything else. If I understand what you want you really want to 
use a PatternSelector. See 
[http://logging.apache.org/log4j/2.x/manual/layouts.html#Pattern_Selectors].


was (Author: [email protected]):
The purpose of a filter is to decide whether an event should be logged. Your 
Alarm filter doesn't seem to be for that purpose as it doesn't even have 
onMatch or onMismatcH attributes. Since the purpose of a filter is to allow an 
event through or block it, it doesn't make sense for a filter's attributes to 
be passed to anything else. If I understand what you want you really want to 
use a PatternSelector. See 
http://logging.apache.org/log4j/2.x/manual/layouts.html#Pattern_Selectors.

> LogEvent attach a map attribute
> -------------------------------
>
>                 Key: LOG4J2-2454
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-2454
>             Project: Log4j 2
>          Issue Type: Improvement
>            Reporter: Lipeng
>            Priority: Minor
>
> We standardize the alarm base on log4j2, there are trigger rules and alarm 
> handle team on the filter, these information will log to file, then our log 
> analysis module will send mail to the team with the filter configuration. but 
> this information can not be passed to the layout module, so I want to add an 
> attribute to pass information between log4j2 components.  
> example
> <AlarmAppender name="alarm">
>     <Filters>
>         <Alarm>
>             <resolver>[email protected]</resolver>
>             <subject>title1</subject>
>             <priority>1</priority>
>             <expression>^hello.*</expression>
>       </Alarm>
>        <Alarm>
>            <resolver>[email protected]</resolver>
>            <subject>title2</subject>
>            <priority>1</priority>
>            <logLevel>error</logLevel>
>        </Alarm>
>     </Filters>
>  </AlarmAppender>



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to