[ 
https://issues.apache.org/jira/browse/LOG4J2-2443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16633428#comment-16633428
 ] 

ASF subversion and git services commented on LOG4J2-2443:
---------------------------------------------------------

Commit a27bd7642be15b41bbc5d63ddf17257f982623f3 in logging-log4j-audit's branch 
refs/heads/master from [~aivanov93]
[ https://git-wip-us.apache.org/repos/asf?p=logging-log4j-audit.git;h=a27bd76 ]

[LOG4J2-2443] optimize imports


> Consistent validation exceptions
> --------------------------------
>
>                 Key: LOG4J2-2443
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-2443
>             Project: Log4j 2
>          Issue Type: Improvement
>          Components: Log4j-Audit
>    Affects Versions: Log4j-Audit 1.0.0
>            Reporter: Andrei Ivanov
>            Priority: Major
>
> Trying to create an {{ExceptionMapper}} for the validation exceptions I 
> notice that there are 2 kind of exceptions that are thrown when logging.
> {{AbstractEventLogger}} mostly throws {{AuditException}}, but there's even a 
> {{IllegalStateException}} thrown, that probably can be changed to an 
> {{AuditException}}.
> But then there's {{LogEventFactory}} that throws 
> {{ConstraintValidationException}} for validation errors.
> I then thought there's an exception hierarchy in place, but it seems there's 
> no relation between {{AuditException}} and {{ConstraintValidationException}}.
> Please consider making {{AbstractEventLogger}} also throw 
> {{ConstraintValidationException}} and maybe create some hierarchy for these 
> exceptions to provide them a common base exception, perhaps 
> {{AuditException}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to