[
https://issues.apache.org/jira/browse/LOG4J2-2443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrei Ivanov closed LOG4J2-2443.
---------------------------------
Looks fine, thank you.
Btw, I'm not sure if you saw my comment regarding the implications for semantic
versioning, as this PR deleted some classes, the unused exceptions.
> Consistent validation exceptions
> --------------------------------
>
> Key: LOG4J2-2443
> URL: https://issues.apache.org/jira/browse/LOG4J2-2443
> Project: Log4j 2
> Issue Type: Improvement
> Components: Log4j-Audit
> Affects Versions: Log4j-Audit 1.0.0
> Reporter: Andrei Ivanov
> Priority: Major
> Fix For: Log4j-Audit 1.0.1
>
>
> Trying to create an {{ExceptionMapper}} for the validation exceptions I
> notice that there are 2 kind of exceptions that are thrown when logging.
> {{AbstractEventLogger}} mostly throws {{AuditException}}, but there's even a
> {{IllegalStateException}} thrown, that probably can be changed to an
> {{AuditException}}.
> But then there's {{LogEventFactory}} that throws
> {{ConstraintValidationException}} for validation errors.
> I then thought there's an exception hierarchy in place, but it seems there's
> no relation between {{AuditException}} and {{ConstraintValidationException}}.
> Please consider making {{AbstractEventLogger}} also throw
> {{ConstraintValidationException}} and maybe create some hierarchy for these
> exceptions to provide them a common base exception, perhaps
> {{AuditException}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
