[jira] [Commented] (LOG4J2-2475) Limit reusable event.clear parameter clearing to argsCount

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/LOG4J2-2475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652539#comment-16652539
 ] 

ASF GitHub Bot commented on LOG4J2-2475:
----------------------------------------

Github user cakofony commented on the issue:

    https://github.com/apache/logging-log4j2/pull/218
  
    n=1000
    ```
    Benchmark                                      Mode  Cnt        Score       
Error  Units
    ManyParametersInSetupBenchmark.fewParameters  thrpt    3  1406346.075 ± 
82926.012  ops/s
    ```
    
    n=100
    ```
    Benchmark                                      Mode  Cnt        Score       
 Error  Units
    ManyParametersInSetupBenchmark.fewParameters  thrpt    3  4332639.602 ± 
232499.236  ops/s
    ```
    
    n=10
    ```
    Benchmark                                      Mode  Cnt        Score       
  Error  Units
    ManyParametersInSetupBenchmark.fewParameters  thrpt    3  5480582.409 ± 
1238380.733  ops/s
    ```
    
    And another run with this change
    ```
    Benchmark                                      Mode  Cnt        Score       
 Error  Units
    ManyParametersInSetupBenchmark.fewParameters  thrpt    3  5814710.334 ± 
899317.421  ops/s
    ```


> Limit reusable event.clear parameter clearing to argsCount
> ----------------------------------------------------------
>
>                 Key: LOG4J2-2475
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-2475
>             Project: Log4j 2
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Carter Kozak
>            Assignee: Carter Kozak
>            Priority: Major
>
> Larger parameter arrays may make their way into log4j when passed into the 
> logger directly. These may take longer to clear, despite only containing one 
> or two parameters.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)