jvz commented on issue #8: LOG4J2-2433 Coroutines Support URL: https://github.com/apache/logging-log4j-kotlin/pull/8#issuecomment-449533982 That sounds better to me! On Fri, Dec 21, 2018 at 16:47, Raman Gupta <[email protected]> wrote: > *@rocketraman* commented on this pull request. > ------------------------------ > > In > log4j-api-kotlin/src/main/kotlin/org/apache/logging/log4j/kotlin/ThreadContextContext.kt > <https://github.com/apache/logging-log4j-kotlin/pull/8#discussion_r243708005> > : > > > + * logger.info { "..." } // The Thread context contains the mapping here > + * } > + * ``` > + * > + * Note, that you cannot update Thread context from inside of the coroutine simply > + * using [ThreadContext.put]. These updates are going to be lost on the next suspension and > + * reinstalled to the Thread context that was captured or explicitly specified in > + * [contextMap] when this object was created on the next resumption. > + * Use `withContext(ThreadContext()) { ... }` to capture updated map of Thread keys and values > + * for the specified block of code. > + * > + * @param contextMap the value of [Thread] context map. > + * Default value is the copy of the current thread's context map that is acquired via > + * [ThreadContext.getContext]. > + */ > +public class ThreadContextContext( > > I struggled with the name. It is actually a Kotlin coroutines "Context", > for a Log4j "ThreadContext". Calling it ThreadContextHolder doesn't seem > quite right either, as it does a bit more than just hold the log4j > ThreadContext. How about CoroutineThreadContext? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/logging-log4j-kotlin/pull/8#discussion_r243708005>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AAwS68B9B66XTsrM_789sRS_34xlNFxEks5u7WT2gaJpZM4ZJSG8> > . > -- Matt Sicker <[email protected]>
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
