garydgregory commented on issue #251: Remove garbage creation introduced by LOG4J2-2301 URL: https://github.com/apache/logging-log4j2/pull/251#issuecomment-453748280 +1 having a failing test, otherwise we are almost guaranteeing the regression will come back :-( Gary On Fri, Jan 11, 2019 at 6:31 PM Remko Popma <[email protected]> wrote: > Yes, that is worrisome. Would be great if we can make the test fail, to > confirm that the patch fixes the issue. > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/logging-log4j2/pull/251#issuecomment-453690349>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/ABIfN4vuFk-79n0rIecPS7mW7XnidjJSks5vCR7rgaJpZM4Z76KQ> > . >
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
