cakofony commented on issue #251: Remove garbage creation introduced by LOG4J2-2301 URL: https://github.com/apache/logging-log4j2/pull/251#issuecomment-454037264 > Can't this be testing with a single thread? I don't believe we can, the issue is that changes in ThreadLocal map size (which can only change by 1 on the current thread, which doesn't trigger the issue) result in allocation of new Entry objects if rehashing/`expungeStaleEntry` has nulled the current value after a hash collision. > would it be possible to submit this patch and tackle the test separately? I would be okay with merging the fix before we put together a test (pending other devs agreement, of course) because: 1. The test will be significantly more complex than the issue 1. We understand why this is happening 1. I have audited the codebase for this pattern, and don't see other occurrences in gc-free code.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
