davebfid opened a new pull request #45: Fix performance issue LOG4NET-429 that was introduced by LOG4NET-205 URL: https://github.com/apache/logging-log4net/pull/45 This pull request fixes the performance issue raised as LOG4NET-429. I think it is a better solution than the potential fixes mentioned in LOG4NET-429. Also I feel its better solution than the one proposed in pull request 10. The change caches 3 things: Name SID When the name was looked up When the user name is required the code performs the following checks: If the cached SID is the same as the current user SID: if its not then the name is looked up again. If cached details are older than 10 seconds: If they are then the name is looked up again. This ensures if a user is renamed (in which case the SID remains the same but the user name will be different) it will be no more than 10 seconds out of date
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
