qub1n commented on issue #46: '(doc)' make the method RollingFileAppender.RollFile() virtual. URL: https://github.com/apache/logging-log4net/pull/46#issuecomment-458581571 Is there a reasoning why the pull request is not based onto develop? -> No, it was just the default option on GitHub, I will change it. OK, please cancel this pull request and I will create a new Pull Request on branch 'develop' with following method signature: protected virtual void OnFileRolled(string fromFile, string toFile){}
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
