cakofony commented on a change in pull request #260: [LOG4J2-2561] JEP223
version detection fix for JDK 9 and up
URL: https://github.com/apache/logging-log4j2/pull/260#discussion_r261825957
##########
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/layout/AbstractStringLayout.java
##########
@@ -134,7 +134,13 @@ private static boolean isPreJava8() {
final String version = System.getProperty("java.version");
Review comment:
Can we make this method delegate to a package-private `static boolean
isPreJava8(String javaVersion)` which we can invoke directly from the test? The
reflective method is likely to cause failures if we refactor this code in the
future, and setting the `java.version` system property may have other
consequences which I'd prefer to avoid.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
