cakofony commented on a change in pull request #260: [LOG4J2-2561] JEP223
version detection fix for JDK 9 and up
URL: https://github.com/apache/logging-log4j2/pull/260#discussion_r262025574
##########
File path:
log4j-api/src/test/java/org/apache/logging/log4j/util/ConstantsTest.java
##########
@@ -0,0 +1,20 @@
+package org.apache.logging.log4j.util;
+
+import org.junit.Test;
+
+import java.lang.reflect.InvocationTargetException;
+import java.lang.reflect.Method;
+import java.util.Properties;
+
+import static org.junit.Assert.*;
+
+public class ConstantsTest {
+
+ @Test
+ public void testJdkVersionDetection() throws NoSuchMethodException,
InvocationTargetException, IllegalAccessException {
Review comment:
nit: No need to declare these exception types now that we're calling
`getMajorVersion` directly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
