cakofony commented on a change in pull request #263: Fix jackson layout
performance regression introduced with LOG4J2-2341
URL: https://github.com/apache/logging-log4j2/pull/263#discussion_r267623037
##########
File path:
log4j-layout-jackson/src/main/java/org/apache/logging/log4j/jackson/AbstractJacksonLayout.java
##########
@@ -216,11 +222,126 @@ public Object getLogEvent() {
protected static final String DEFAULT_EOL = "\r\n";
protected static final String COMPACT_EOL = Strings.EMPTY;
private static LogEvent convertMutableToLog4jEvent(final LogEvent event) {
- // TODO Jackson-based layouts have certain filters set up for
Log4jLogEvent.
- // TODO Need to set up the same filters for MutableLogEvent but don't
know how...
- // This is a workaround.
Review comment:
These comments do not appear to be correct. The code is confusing because we
register a Jackson property filter using id
`org.apache.logging.log4j.core.impl.Log4jLogEvent`, however the code is not at
all specific to Log4jLogEvent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
