[
https://issues.apache.org/jira/browse/LOG4J2-2551?focusedWorklogId=221682&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-221682
]
ASF GitHub Bot logged work on LOG4J2-2551:
------------------------------------------
Author: ASF GitHub Bot
Created on: 02/Apr/19 10:28
Start Date: 02/Apr/19 10:28
Worklog Time Spent: 10m
Work Description: andrei-ivanov commented on pull request #15:
LOG4J2-2551: normalize event name when creating the AuditMessage
URL: https://github.com/apache/logging-log4j-audit/pull/15
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 221682)
Time Spent: 10m
Remaining Estimate: 0h
> Event starting with upper case not found by AbstractEventLogger.logEvent
> ------------------------------------------------------------------------
>
> Key: LOG4J2-2551
> URL: https://issues.apache.org/jira/browse/LOG4J2-2551
> Project: Log4j 2
> Issue Type: Bug
> Components: Log4j-Audit
> Affects Versions: Log4j-Audit 1.0.1
> Reporter: Andrei Ivanov
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> As a consequence of my changes for LOG4J2-2442, I've introduced a regression
> when the name of the event starts with an upper case letter 😫
> As a fix, I'm not sure about the approach:
> 1. Move the normalization of the name when constructing the {{AuditMessage}},
> from line
> [94|https://github.com/apache/logging-log4j-audit/blob/master/log4j-audit/log4j-audit-api/src/main/java/org/apache/logging/log4j/audit/AbstractEventLogger.java#L94]
> to
> [106|https://github.com/apache/logging-log4j-audit/blob/master/log4j-audit/log4j-audit-api/src/main/java/org/apache/logging/log4j/audit/AbstractEventLogger.java#L106]
> 2. Remove name normalization completely and use the exact name used in the
> event definition.
> I actually think I like option 2 better.
> What do you think?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
